On Tue, Mar 23, 2010 at 6:37 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, Mar 23, 2010 at 1:57 PM, Sedat Dilek <sedat.di...@googlemail.com> > wrote: >> >> Thanks for the turbo fix, but you workarounded the "real" bug. > > Frankly, the Mesa build system isn't my area and I don't want to have > anything to do with it. >
This was the first time for me to have a closer look into the build-system and I am still learning to understand. > The square microtiling is now disabled on both older kernels which don't > support it and older libdrm's which don't have the flag defined. No need to > have bleeding-edge stuff of everything is the way to go as long as it > doesn't get messy. > No problem with that kind of strategy and I am really happy we don't need a depends version-bump. One small critic as I have noticed several times in your commits: It's helpful for people following the WIP development to have some documented text in the commit-body especially when it is fixing: * a previous b0rked commit - by adding its commit-no * an fd.o bug - by adding its bug-no * ... -- Sedat ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
