----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review3712 -----------------------------------------------------------
src/Makefile.in <https://reviews.apache.org/r/3050/#comment8323> MONITORING_OBJ should be set to empty string unconditionally first. src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8319> Why strings? (and elsewhere) src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8309> Why milliseconds? libprocess uses seconds since some time, and I think USER_HZ usually (often?) isn't 1000. src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8320> Please state whether RSS or VSIZE or something else. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8316> include all system .h headers either before or after standard C++ headers. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8315> Please make these file-scoped (static or anonymous namespace) or put them in the header file. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8311> O is a pretty bad variable name. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8313> Check whether this read succeeds. - Charles On 2011-12-07 07:08:06, Alex Degtiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > > (Updated 2011-12-07 07:08:06) > > > Review request for mesos. > > > Summary > ------- > > The first of several patches related to resource usage monitoring. This patch > provides a collection of utilities for use on Linux for reading stats from > proc. It is used by both the lxc and proc resource collectors. > > > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > > > Diffs > ----- > > src/tests/Makefile.in ea943f7 > src/tests/proc_utils_tests.cpp PRE-CREATION > src/Makefile.in 516f128 > src/monitoring/proc_utils.hpp PRE-CREATION > src/monitoring/proc_utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/3050/diff > > > Testing > ------- > > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all > utility functions, and functions have been tested ad hoc. > > > Thanks, > > Alex > >
