----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review3745 -----------------------------------------------------------
src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8438> Brace on newline. src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8439> Use seconds or milliseconds _abstraction_ from common/seconds.hpp. src/monitoring/proc_utils.hpp <https://reviews.apache.org/r/3050/#comment8440> Seconds or milliseconds type, here and everywhere else. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8443> Brace on newline. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8444> Double newline between functions. src/monitoring/proc_utils.cpp <https://reviews.apache.org/r/3050/#comment8445> Add more spaces between logical blocks. - Benjamin On 2011-12-08 00:00:32, Alex Degtiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > > (Updated 2011-12-08 00:00:32) > > > Review request for mesos. > > > Summary > ------- > > The first of several patches related to resource usage monitoring. This patch > provides a collection of utilities for use on Linux for reading stats from > proc. It is used by both the lxc and proc resource collectors. > > > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > > > Diffs > ----- > > src/tests/Makefile.in ea943f7 > src/tests/proc_utils_tests.cpp PRE-CREATION > src/monitoring/proc_utils.cpp PRE-CREATION > src/Makefile.in 516f128 > src/monitoring/proc_utils.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/3050/diff > > > Testing > ------- > > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all > utility functions, and functions have been tested ad hoc. > > > Thanks, > > Alex > >
