> On 2011-12-08 18:48:30, Benjamin Hindman wrote: > >
Also, as discussed, I created a monitoring/linux folder to put all linux-specific source files. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, line 33 > > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line33> > > > > Brace on newline. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 43 > > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line43> > > > > Brace on newline. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 60 > > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line60> > > > > Double newline between functions. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, lines 38-39 > > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line38> > > > > Use seconds or milliseconds _abstraction_ from common/seconds.hpp. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, line 53 > > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line53> > > > > Seconds or milliseconds type, here and everywhere else. Done. Went with seconds for consistency with rest of Mesos. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 76 > > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line76> > > > > Add more spaces between logical blocks. Done. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review3745 ----------------------------------------------------------- On 2011-12-08 00:00:32, Alex Degtiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > > (Updated 2011-12-08 00:00:32) > > > Review request for mesos. > > > Summary > ------- > > The first of several patches related to resource usage monitoring. This patch > provides a collection of utilities for use on Linux for reading stats from > proc. It is used by both the lxc and proc resource collectors. > > > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > > > Diffs > ----- > > src/tests/Makefile.in ea943f7 > src/tests/proc_utils_tests.cpp PRE-CREATION > src/monitoring/proc_utils.cpp PRE-CREATION > src/Makefile.in 516f128 > src/monitoring/proc_utils.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/3050/diff > > > Testing > ------- > > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all > utility functions, and functions have been tested ad hoc. > > > Thanks, > > Alex > >
