> On 2012-02-29 04:02:37, Charles Reiss wrote: > > hadoop/TUTORIAL.sh, line 65 > > <https://reviews.apache.org/r/4100/diff/2/?file=86493#file86493line65> > > > > This will pollute the source directory even though you require an > > out-of-source build. > > Benjamin Hindman wrote: > I technically don't require an out-of-source build, but I think the > tutorial reads that way. I can update the document. Yes, it will pollute the > source directory, but it's just a single directory that gets created (kind of > like build) so it shouldn't be too tricky to reason about with git. Do you > have a better suggestion?
I won't disapprove of doing it the way it works now, but I'd prefer that you extract the tarball/do the patching in the build directory. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4100/#review5432 ----------------------------------------------------------- On 2012-02-29 06:17:27, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4100/ > ----------------------------------------------------------- > > (Updated 2012-02-29 06:17:27) > > > Review request for mesos, Andy Konwinski, Charles Reiss, and Matei Zaharia. > > > Summary > ------- > > make && make hadoop > > > Diffs > ----- > > Makefile.am abee0b9 > hadoop/TUTORIAL.sh PRE-CREATION > hadoop/hadoop-0.20.205.0.patch PRE-CREATION > hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-0.20.205.0_conf_mapred-site.xml.patch PRE-CREATION > src/Makefile.am a1ff40c > src/examples/java/TestExecutor.java 6211490 > src/java/jni/convert.cpp 04a25dd > src/java/src/org/apache/mesos/Log.java 4612393 > src/java/src/org/apache/mesos/MesosExecutorDriver.java 4f110ca > src/java/src/org/apache/mesos/MesosNativeLibrary.java PRE-CREATION > src/java/src/org/apache/mesos/MesosSchedulerDriver.java f135ffb > > Diff: https://reviews.apache.org/r/4100/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
