----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4100/#review5520 -----------------------------------------------------------
src/java/jni/convert.cpp <https://reviews.apache.org/r/4100/#comment11941> I think you're supposed to. I'm not sure how often a load followed by unload happens though. src/java/src/org/apache/mesos/MesosNativeLibrary.java <https://reviews.apache.org/r/4100/#comment11942> It would be nice not to use println here so as not to pollute the user program's output. Instead, maybe do it only if you're about to throw an exception, or include it in the exception's message. - Matei On 2012-02-29 06:17:27, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4100/ > ----------------------------------------------------------- > > (Updated 2012-02-29 06:17:27) > > > Review request for mesos, Andy Konwinski, Charles Reiss, and Matei Zaharia. > > > Summary > ------- > > make && make hadoop > > > Diffs > ----- > > Makefile.am abee0b9 > hadoop/TUTORIAL.sh PRE-CREATION > hadoop/hadoop-0.20.205.0.patch PRE-CREATION > hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-0.20.205.0_conf_mapred-site.xml.patch PRE-CREATION > src/Makefile.am a1ff40c > src/examples/java/TestExecutor.java 6211490 > src/java/jni/convert.cpp 04a25dd > src/java/src/org/apache/mesos/Log.java 4612393 > src/java/src/org/apache/mesos/MesosExecutorDriver.java 4f110ca > src/java/src/org/apache/mesos/MesosNativeLibrary.java PRE-CREATION > src/java/src/org/apache/mesos/MesosSchedulerDriver.java f135ffb > > Diff: https://reviews.apache.org/r/4100/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
