----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4981/#review7516 -----------------------------------------------------------
src/state/state.hpp <https://reviews.apache.org/r/4981/#comment16640> s/declarations/declaration src/state/state.hpp <https://reviews.apache.org/r/4981/#comment16641> consider moving this into a function isValid() to make the intention clear src/state/state.hpp <https://reviews.apache.org/r/4981/#comment16643> ws src/state/state.cpp <https://reviews.apache.org/r/4981/#comment16645> why not wrap this in if(db != NULL) then? src/tests/state_tests.cpp <https://reviews.apache.org/r/4981/#comment16649> s/ASSERT/EXPECT because you always to do the rmdir() irrespective of your test succcess/failure - Vinod On 2012-05-03 19:50:24, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4981/ > ----------------------------------------------------------- > > (Updated 2012-05-03 19:50:24) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > This is the beginning of a the components for saving "state" information, > including what slaves are connected, what frameworks are running, etc. I'll > be adding a ZooKeeperState implementation soon, and the master and it's > components will use it to save state in a distributed way. > > > Diffs > ----- > > src/messages/state.proto PRE-CREATION > src/state/leveldb.cpp PRE-CREATION > src/state/state.hpp PRE-CREATION > src/state/zookeeper.cpp PRE-CREATION > src/messages/state.hpp PRE-CREATION > src/Makefile.am cd503a8 > src/tests/state_tests.cpp PRE-CREATION > src/zookeeper/group.cpp da2e147 > > Diff: https://reviews.apache.org/r/4981/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
