----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4981/#review7569 -----------------------------------------------------------
src/state/state.hpp <https://reviews.apache.org/r/4981/#comment16759> why pointer instead of ref? src/state/leveldb.cpp <https://reviews.apache.org/r/4981/#comment16754> reorder src/state/leveldb.cpp <https://reviews.apache.org/r/4981/#comment16757> weren't u gonna use Result instead? src/state/leveldb.cpp <https://reviews.apache.org/r/4981/#comment16756> swap feels like a bad name here. update/insert perhaps? - Vinod On 2012-05-04 00:37:51, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4981/ > ----------------------------------------------------------- > > (Updated 2012-05-04 00:37:51) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > This is the beginning of a the components for saving "state" information, > including what slaves are connected, what frameworks are running, etc. I'll > be adding a ZooKeeperState implementation soon, and the master and it's > components will use it to save state in a distributed way. > > > Diffs > ----- > > src/Makefile.am cd503a8 > src/messages/state.hpp PRE-CREATION > src/messages/state.proto PRE-CREATION > src/state/leveldb.cpp PRE-CREATION > src/state/state.hpp PRE-CREATION > src/state/zookeeper.cpp PRE-CREATION > src/tests/base_zookeeper_test.hpp f35acc0 > src/tests/state_tests.cpp PRE-CREATION > src/zookeeper/group.cpp da2e147 > > Diff: https://reviews.apache.org/r/4981/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
