> On 2012-05-04 17:33:56, Vinod Kone wrote: > > src/state/leveldb.cpp, lines 1-3 > > <https://reviews.apache.org/r/4981/diff/4/?file=106631#file106631line1> > > > > reorder
But this is two deep verssus three deep ... > On 2012-05-04 17:33:56, Vinod Kone wrote: > > src/state/state.hpp, line 112 > > <https://reviews.apache.org/r/4981/diff/1-4/?file=106104#file106104line112> > > > > why pointer instead of ref? Because I need to change variable->entry (see the body). > On 2012-05-04 17:33:56, Vinod Kone wrote: > > src/state/leveldb.cpp, line 84 > > <https://reviews.apache.org/r/4981/diff/4/?file=106631#file106631line84> > > > > weren't u gonna use Result instead? Try is sufficient here, Result is used in the ZK implementation. > On 2012-05-04 17:33:56, Vinod Kone wrote: > > src/state/leveldb.cpp, line 94 > > <https://reviews.apache.org/r/4981/diff/4/?file=106631#file106631line94> > > > > swap feels like a bad name here. update/insert perhaps? Well, I'm trying to capture the fact that I want to swap the entry that exists only if it has the UUID that gets passed in ... this is coming from the compare-and-swap name. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4981/#review7569 ----------------------------------------------------------- On 2012-05-04 00:37:51, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4981/ > ----------------------------------------------------------- > > (Updated 2012-05-04 00:37:51) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > This is the beginning of a the components for saving "state" information, > including what slaves are connected, what frameworks are running, etc. I'll > be adding a ZooKeeperState implementation soon, and the master and it's > components will use it to save state in a distributed way. > > > Diffs > ----- > > src/Makefile.am cd503a8 > src/messages/state.hpp PRE-CREATION > src/messages/state.proto PRE-CREATION > src/state/leveldb.cpp PRE-CREATION > src/state/state.hpp PRE-CREATION > src/state/zookeeper.cpp PRE-CREATION > src/tests/base_zookeeper_test.hpp f35acc0 > src/tests/state_tests.cpp PRE-CREATION > src/zookeeper/group.cpp da2e147 > > Diff: https://reviews.apache.org/r/4981/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
