> On 2012-05-17 14:15:32, John Sirois wrote: > > src/Makefile.am, line 195 > > <https://reviews.apache.org/r/5132/diff/1/?file=109077#file109077line195> > > > > I assume there is autotools magic keeping linux/proc.hpp out of darwin > > compiles for example? That header does > > #include <linux/version.h> > > > > And later tests: > > LINUX_VERSION_CODE > > > > Which I would guess fails on non-linucies
Yes, the .cpp files are only included when OS_LINUX is true. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5132/#review7959 ----------------------------------------------------------- On 2012-05-15 22:34:27, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5132/ > ----------------------------------------------------------- > > (Updated 2012-05-15 22:34:27) > > > Review request for mesos, Alex Degtiar, John Sirois, Vinod Kone, and Jie Yu. > > > Summary > ------- > > This patch is a refactor of some parts of the patch at > https://reviews.apache.org/r/4167. The plan is to take the components from > that patch, break them into smaller patches, and get them committed. > > > Diffs > ----- > > src/Makefile.am 333234d > src/linux/proc.hpp PRE-CREATION > src/linux/proc.cpp PRE-CREATION > src/tests/proc_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5132/diff > > > Testing > ------- > > On a Linux machine: > > make check > > > Thanks, > > Benjamin > >
