> On 2012-05-15 23:40:05, Vinod Kone wrote:
> > src/linux/proc.hpp, line 61
> > <https://reviews.apache.org/r/5132/diff/1/?file=109078#file109078line61>
> >
> >     doc

Done.


> On 2012-05-15 23:40:05, Vinod Kone wrote:
> > src/linux/proc.cpp, line 129
> > <https://reviews.apache.org/r/5132/diff/1/?file=109079#file109079line129>
> >
> >     is this format guaranteed?

Yup.


> On 2012-05-15 23:40:05, Vinod Kone wrote:
> > src/tests/proc_tests.cpp, lines 44-45
> > <https://reviews.apache.org/r/5132/diff/1/?file=109080#file109080line44>
> >
> >     s/EXPECT_NE(0/EXPECT_EQ(1/

Done.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5132/#review7920
-----------------------------------------------------------


On 2012-05-15 22:34:27, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5132/
> -----------------------------------------------------------
> 
> (Updated 2012-05-15 22:34:27)
> 
> 
> Review request for mesos, Alex Degtiar, John Sirois, Vinod Kone, and Jie Yu.
> 
> 
> Summary
> -------
> 
> This patch is a refactor of some parts of the patch at 
> https://reviews.apache.org/r/4167. The plan is to take the components from 
> that patch, break them into smaller patches, and get them committed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 333234d 
>   src/linux/proc.hpp PRE-CREATION 
>   src/linux/proc.cpp PRE-CREATION 
>   src/tests/proc_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5132/diff
> 
> 
> Testing
> -------
> 
> On a Linux machine:
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>

Reply via email to