> On 2012-05-16 00:41:59, Alex Degtiar wrote: > > src/linux/proc.hpp, line 73 > > <https://reviews.apache.org/r/5132/diff/1/?file=109078#file109078line73> > > > > Some of these fields, including ppid, session, and perhaps pgrp and > > others, have the pid_t type according to unistd.h. Do we want to be > > consistent with that, or is there a reason to keep them as ints?
You're right! Awesome catch! I'm switching them to pid_t. Thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5132/#review7922 ----------------------------------------------------------- On 2012-05-15 22:34:27, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5132/ > ----------------------------------------------------------- > > (Updated 2012-05-15 22:34:27) > > > Review request for mesos, Alex Degtiar, John Sirois, Vinod Kone, and Jie Yu. > > > Summary > ------- > > This patch is a refactor of some parts of the patch at > https://reviews.apache.org/r/4167. The plan is to take the components from > that patch, break them into smaller patches, and get them committed. > > > Diffs > ----- > > src/Makefile.am 333234d > src/linux/proc.hpp PRE-CREATION > src/linux/proc.cpp PRE-CREATION > src/tests/proc_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5132/diff > > > Testing > ------- > > On a Linux machine: > > make check > > > Thanks, > > Benjamin > >
