----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6617/#review10375 -----------------------------------------------------------
src/files/files.hpp <https://reviews.apache.org/r/6617/#comment22073> newline if two includes do not share the same prefix. src/files/files.cpp <https://reviews.apache.org/r/6617/#comment22079> Instead of opening the file here, can we have a new API os::access in stout which wraps the libc function "access"? src/files/files.cpp <https://reviews.apache.org/r/6617/#comment22083> Can we provide APIs in stout/os that basically have the same semantics as that in python APIs like os.path.isdir(path), os.path.isfile(path), etc. src/files/files.cpp <https://reviews.apache.org/r/6617/#comment22084> We can get rid of it once we have the APIs above. src/files/files.cpp <https://reviews.apache.org/r/6617/#comment22085> Is there any other way to check whether the 'name' is a directory or not? This is not quite elegant to me:) src/files/files.cpp <https://reviews.apache.org/r/6617/#comment22088> Yes, i think you need to delete the 'process' as it is spawned without setting manage=true. src/tests/utils.hpp <https://reviews.apache.org/r/6617/#comment22089> Can we just use mkdir here? The new name looks a little weird to me:) - Jie Yu On Aug. 15, 2012, 2:48 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6617/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 2:48 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu. > > > Description > ------- > > Implementing the file abstraction and http endpoints for file reading / > browsing. > > > This addresses bug MESOS-255. > https://issues.apache.org/jira/browse/MESOS-255 > > > Diffs > ----- > > src/Makefile.am b0cb6cc > src/files/files.hpp d0cab91 > src/files/files.cpp d4080d4 > src/tests/configurator_tests.cpp c2f5aa0 > src/tests/files_tests.cpp PRE-CREATION > src/tests/utils.hpp caf5926 > third_party/libprocess/include/stout/json.hpp 25dbcf4 > third_party/libprocess/include/stout/path.hpp 80d9bc6 > > Diff: https://reviews.apache.org/r/6617/diff/ > > > Testing > ------- > > Added files_tests.cpp > make check > > > Thanks, > > Ben Mahler > >
