-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6617/
-----------------------------------------------------------
(Updated Aug. 22, 2012, 1:37 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Changes
-------
this now has an http::get() which performs a _blocking_ get, I went down a
rabbit-hole trying to write the async version so pairing on that part would be
great! (can't quite re-use io::read as my TODO indicates).
this review is getting quite large, so we may want to sit down together and go
through it, esp. if making get async
Description
-------
Implementing the file abstraction and http endpoints for file reading /
browsing.
This addresses bug MESOS-255.
https://issues.apache.org/jira/browse/MESOS-255
Diffs (updated)
-----
src/Makefile.am aaceee3
src/files/files.hpp d0cab91
src/files/files.cpp d4080d4
src/logging/logging.cpp 6909b0b
src/master/http.cpp c480bc6
src/master/slaves_manager.cpp e25efd0
src/slave/http.cpp a1f7926
src/tests/configurator_tests.cpp c2f5aa0
src/tests/files_tests.cpp PRE-CREATION
src/tests/utils.hpp 83d5daa
src/webui/master/static/controllers.js 1606e64
third_party/libprocess/include/process/http.hpp 8424ca6
third_party/libprocess/include/process/io.hpp 6a40b18
third_party/libprocess/include/stout/hashmap.hpp 51bdea0
third_party/libprocess/include/stout/json.hpp 25dbcf4
third_party/libprocess/include/stout/os.hpp b1eceb3
third_party/libprocess/include/stout/path.hpp 80d9bc6
third_party/libprocess/include/stout/stringify.hpp ad2f2fa
third_party/libprocess/src/decoder.hpp 105fe5d
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/src/process.cpp 78069bf
third_party/libprocess/src/statistics.cpp d05b327
Diff: https://reviews.apache.org/r/6617/diff/
Testing
-------
Added files_tests.cpp
make check
Thanks,
Ben Mahler
