> On Aug. 16, 2012, 12:12 a.m., Jie Yu wrote: > > src/files/files.cpp, line 108 > > <https://reviews.apache.org/r/6617/diff/1/?file=140338#file140338line108> > > > > Instead of opening the file here, can we have a new API os::access in > > stout which wraps the libc function "access"?
+1 - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6617/#review10375 ----------------------------------------------------------- On Aug. 15, 2012, 2:48 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6617/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 2:48 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu. > > > Description > ------- > > Implementing the file abstraction and http endpoints for file reading / > browsing. > > > This addresses bug MESOS-255. > https://issues.apache.org/jira/browse/MESOS-255 > > > Diffs > ----- > > src/Makefile.am b0cb6cc > src/files/files.hpp d0cab91 > src/files/files.cpp d4080d4 > src/tests/configurator_tests.cpp c2f5aa0 > src/tests/files_tests.cpp PRE-CREATION > src/tests/utils.hpp caf5926 > third_party/libprocess/include/stout/json.hpp 25dbcf4 > third_party/libprocess/include/stout/path.hpp 80d9bc6 > > Diff: https://reviews.apache.org/r/6617/diff/ > > > Testing > ------- > > Added files_tests.cpp > make check > > > Thanks, > > Ben Mahler > >
