----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6739/#review10705 -----------------------------------------------------------
src/common/attributes.hpp <https://reviews.apache.org/r/6739/#comment23094> Why is this up here instead of internal? src/local/local.cpp <https://reviews.apache.org/r/6739/#comment23096> not yours, but can you change these to doubles? src/slave/slave.cpp <https://reviews.apache.org/r/6739/#comment23103> instead of setting this to an arbitrary value, it would be nice to actually know much is available (or free) on the host. feel free to add a TODO. the slave gc review i sent out has os::usage() that calculates current usage. may be we can add os:free() as a complement. src/webui/master/static/frameworks.html <https://reviews.apache.org/r/6739/#comment23104> sweet src/webui/master/static/home.html <https://reviews.apache.org/r/6739/#comment23105> noob question. why do u need to pipe it through number? isn't it only used for doubles? src/webui/master/static/home.html <https://reviews.apache.org/r/6739/#comment23106> ws src/webui/master/static/home.html <https://reviews.apache.org/r/6739/#comment23107> ws - Vinod Kone On Aug. 23, 2012, 12:31 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6739/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See summary. Also attached a screenshot of the stats. > > > This addresses bug MESOS-259. > https://issues.apache.org/jira/browse/MESOS-259 > > > Diffs > ----- > > src/common/attributes.hpp c91e82e > src/common/attributes.cpp 77be97c > src/local/local.hpp 96a1206 > src/local/local.cpp 742bf0c > src/master/http.cpp c480bc6 > src/slave/http.cpp a1f7926 > src/slave/slave.cpp 4efd41e > src/tests/exception_tests.cpp d0d17c4 > src/tests/fault_tolerance_tests.cpp 3cbab2b > src/tests/resource_offers_tests.cpp 6718fb1 > src/webui/master/static/controllers.js 1606e64 > src/webui/master/static/framework.html 958a3d8 > src/webui/master/static/frameworks.html 6e087fc > src/webui/master/static/home.html 319fcb8 > src/webui/master/static/mesos.css 97a8901 > src/webui/master/static/slaves.html 735d60d > third_party/libprocess/include/stout/strings.hpp 5bf0489 > > Diff: https://reviews.apache.org/r/6739/diff/ > > > Testing > ------- > > make check > ./mesos-local.sh > > > Thanks, > > Ben Mahler > >
