> On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/webui/master/static/home.html, line 48 > > <https://reviews.apache.org/r/6739/diff/2/?file=144251#file144251line48> > > > > noob question. why do u need to pipe it through number? isn't it only > > used for doubles?
number also uses commas for humans (1124 | number => 1,124) also, in javascript, all numbers are doubles ;) (Numbers in JavaScript are "double-precision 64-bit format IEEE 754 values", according to the spec.) > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/webui/master/static/home.html, line 123 > > <https://reviews.apache.org/r/6739/diff/2/?file=144251#file144251line123> > > > > ws killed > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/webui/master/static/home.html, line 251 > > <https://reviews.apache.org/r/6739/diff/2/?file=144251#file144251line251> > > > > ws killed > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 25 > > <https://reviews.apache.org/r/6739/diff/2/?file=144250#file144250line25> > > > > sweet yeah, took me a bit to think of this nice abstraction, you should have seen the sorting stuff before > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/common/attributes.hpp, line 37 > > <https://reviews.apache.org/r/6739/diff/2/?file=144238#file144238line37> > > > > Why is this up here instead of internal? based on how it's done in resources.hpp > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 116 > > <https://reviews.apache.org/r/6739/diff/2/?file=144244#file144244line116> > > > > instead of setting this to an arbitrary value, it would be nice to > > actually know much is available (or free) on the host. feel free to add a > > TODO. > > > > the slave gc review i sent out has os::usage() that calculates current > > usage. may be we can add os:free() as a complement. nice, I've added a free() for this > On Aug. 23, 2012, 9:16 p.m., Vinod Kone wrote: > > src/local/local.cpp, lines 70-72 > > <https://reviews.apache.org/r/6739/diff/2/?file=144241#file144241line70> > > > > not yours, but can you change these to doubles? so I've changed cpus to double since it can be fractional right? mem and disk I've changed to uint64_t's to match what the syscalls can return (even though these are in MB) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6739/#review10705 ----------------------------------------------------------- On Aug. 23, 2012, 12:31 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6739/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See summary. Also attached a screenshot of the stats. > > > This addresses bug MESOS-259. > https://issues.apache.org/jira/browse/MESOS-259 > > > Diffs > ----- > > src/common/attributes.hpp c91e82e > src/common/attributes.cpp 77be97c > src/local/local.hpp 96a1206 > src/local/local.cpp 742bf0c > src/master/http.cpp c480bc6 > src/slave/http.cpp a1f7926 > src/slave/slave.cpp 4efd41e > src/tests/exception_tests.cpp d0d17c4 > src/tests/fault_tolerance_tests.cpp 3cbab2b > src/tests/resource_offers_tests.cpp 6718fb1 > src/webui/master/static/controllers.js 1606e64 > src/webui/master/static/framework.html 958a3d8 > src/webui/master/static/frameworks.html 6e087fc > src/webui/master/static/home.html 319fcb8 > src/webui/master/static/mesos.css 97a8901 > src/webui/master/static/slaves.html 735d60d > third_party/libprocess/include/stout/strings.hpp 5bf0489 > > Diff: https://reviews.apache.org/r/6739/diff/ > > > Testing > ------- > > make check > ./mesos-local.sh > > > Thanks, > > Ben Mahler > >
