----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6739/#review11487 -----------------------------------------------------------
src/slave/http.cpp <https://reviews.apache.org/r/6739/#comment24596> I probably missed some of these, but please put a space between foreach and ( everywhere. - Benjamin Hindman On Sept. 10, 2012, 10:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6739/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 10:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See summary. Also attached a screenshot of the stats. > > > This addresses bug MESOS-259. > https://issues.apache.org/jira/browse/MESOS-259 > > > Diffs > ----- > > src/common/attributes.hpp c91e82e > src/common/attributes.cpp 7de35bb > src/common/resources.hpp 6e61791 > src/common/resources.cpp 6a36e28 > src/common/values.hpp c916e31 > src/common/values.cpp e1726c7 > src/local/local.hpp 96a1206 > src/local/local.cpp e077327 > src/master/http.cpp aebaf52 > src/slave/http.cpp 435ab8b > src/slave/slave.cpp 4ea1db1 > src/tests/exception_tests.cpp bb3f2c2 > src/tests/fault_tolerance_tests.cpp 35cf7a8 > src/tests/resource_offers_tests.cpp 148fc8a > src/webui/master/static/controllers.js 41cec18 > src/webui/master/static/framework.html 958a3d8 > src/webui/master/static/frameworks.html 6e087fc > src/webui/master/static/home.html 319fcb8 > src/webui/master/static/mesos.css 97a8901 > src/webui/master/static/slaves.html 735d60d > third_party/libprocess/Makefile.am eb45801 > third_party/libprocess/include/stout/os.hpp 602db1f > third_party/libprocess/include/stout/strings.hpp aca0b02 > > Diff: https://reviews.apache.org/r/6739/diff/ > > > Testing > ------- > > make check > ./mesos-local.sh > > > Thanks, > > Ben Mahler > >
