[
https://issues.apache.org/jira/browse/MESOS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445107#comment-13445107
]
Benjamin Mahler edited comment on MESOS-264 at 8/31/12 4:10 AM:
----------------------------------------------------------------
You're right, reviewboard doesn't keep the binary portion of the diff when you
download from there.
I've attached a file to the change: https://reviews.apache.org/r/6812
(unfortunately, apache only takes files <= 10MB)
Thanks for the patience, the attached patch should be working for you:
$ git apply --binary ~/linux_build_fix.patch
$ git status
# On branch apache_trunk
# Changes not staged for commit:
# (use "git add/rm <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# modified: src/flags/flags.hpp
# modified: src/java/jni/convert.cpp
# modified: src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp
# modified: src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
# modified: src/jvm/jvm.cpp
# modified: src/jvm/jvm.hpp
# modified: src/linux/fs.cpp
# modified: src/linux/proc.cpp
# modified: src/master/drf_sorter.hpp
# modified: src/slave/lxc_isolation_module.cpp
# modified: src/tests/allocator_tests.cpp
# modified: src/tests/proc_tests.cpp
# modified: src/zookeeper/zookeeper.cpp
# deleted: third_party/boost-1.37.0.tar.gz
# modified: third_party/libprocess/include/process/event.hpp
# modified: third_party/libprocess/include/process/filter.hpp
# modified: third_party/libprocess/include/stout/foreach.hpp
# modified: third_party/libprocess/src/encoder.hpp
# deleted: third_party/libprocess/third_party/boost-1.37.0.tar.gz
# modified: third_party/libprocess/third_party/versions.am
# modified: third_party/versions.am
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
#
# third_party/boost-1.51.0.tar.gz
# third_party/libprocess/third_party/boost-1.51.0.tar.gz
was (Author: bmahler):
You're right, reviewboard doesn't keep the binary portion of the diff when
you download from there.
I've attached a file to the change: https://reviews.apache.org/r/6812
(unfortunately, apache only takes files <= 10MB)
Thanks for the patience, the attached patch should be working for you:
{code}
$ git apply --binary ~/linux_build_fix.patch
$ git status
# On branch apache_trunk
# Changes not staged for commit:
# (use "git add/rm <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# modified: src/flags/flags.hpp
# modified: src/java/jni/convert.cpp
# modified: src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp
# modified: src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
# modified: src/jvm/jvm.cpp
# modified: src/jvm/jvm.hpp
# modified: src/linux/fs.cpp
# modified: src/linux/proc.cpp
# modified: src/master/drf_sorter.hpp
# modified: src/slave/lxc_isolation_module.cpp
# modified: src/tests/allocator_tests.cpp
# modified: src/tests/proc_tests.cpp
# modified: src/zookeeper/zookeeper.cpp
# deleted: third_party/boost-1.37.0.tar.gz
# modified: third_party/libprocess/include/process/event.hpp
# modified: third_party/libprocess/include/process/filter.hpp
# modified: third_party/libprocess/include/stout/foreach.hpp
# modified: third_party/libprocess/src/encoder.hpp
# deleted: third_party/libprocess/third_party/boost-1.37.0.tar.gz
# modified: third_party/libprocess/third_party/versions.am
# modified: third_party/versions.am
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
#
# third_party/boost-1.51.0.tar.gz
# third_party/libprocess/third_party/boost-1.51.0.tar.gz
{code}
> Make fails on the latest ubuntu
> -------------------------------
>
> Key: MESOS-264
> URL: https://issues.apache.org/jira/browse/MESOS-264
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Linux Jie-Ubuntu-VM 3.2.0-29-generic #46-Ubuntu SMP Fri
> Jul 27 17:03:23 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
> g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
> Reporter: Jie Yu
> Assignee: Benjamin Mahler
>
> make[2]: Entering directory `/home/jieyu/workspace/mesos/build/src'
> /bin/bash ../libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"mesos\"
> -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.9.0\"
> -DPACKAGE_STRING=\"mesos\ 0.9.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\"
> -DPACKAGE=\"mesos\" -DVERSION=\"0.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
> -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
> -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DMESOS_HAS_JAVA=1
> -DMESOS_HAS_PYTHON=1 -DMESOS_WEBUI=1 -I. -I../../src -Wall -Werror
> -DMESOS_WEBUI_DIR=\"/home/jieyu/workspace/mesos/dist/share/mesos/webui\"
> -DMESOS_LIBEXECDIR=\"/home/jieyu/workspace/mesos/dist/libexec/mesos\"
> -I../../include -I../../third_party/libprocess/include -I../include
> -I../third_party/boost-1.37.0 -I../third_party/protobuf-2.4.1/src
> -I../third_party/glog-0.3.1/src
> -I../third_party/zookeeper-3.3.4/src/c/include
> -I../third_party/zookeeper-3.3.4/src/c/generated -pthread -g2 -O2 -MT
> sched/libmesos_no_third_party_la-sched.lo -MD -MP -MF
> sched/.deps/libmesos_no_third_party_la-sched.Tpo -c -o
> sched/libmesos_no_third_party_la-sched.lo `test -f 'sched/sched.cpp' || echo
> '../../src/'`sched/sched.cpp
> libtool: compile: g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\"
> -DPACKAGE_VERSION=\"0.9.0\" "-DPACKAGE_STRING=\"mesos 0.9.0\""
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\"
> -DVERSION=\"0.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
> -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
> -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1
> -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DMESOS_HAS_JAVA=1
> -DMESOS_HAS_PYTHON=1 -DMESOS_WEBUI=1 -I. -I../../src -Wall -Werror
> -DMESOS_WEBUI_DIR=\"/home/jieyu/workspace/mesos/dist/share/mesos/webui\"
> -DMESOS_LIBEXECDIR=\"/home/jieyu/workspace/mesos/dist/libexec/mesos\"
> -I../../include -I../../third_party/libprocess/include -I../include
> -I../third_party/boost-1.37.0 -I../third_party/protobuf-2.4.1/src
> -I../third_party/glog-0.3.1/src
> -I../third_party/zookeeper-3.3.4/src/c/include
> -I../third_party/zookeeper-3.3.4/src/c/generated -pthread -g2 -O2 -MT
> sched/libmesos_no_third_party_la-sched.lo -MD -MP -MF
> sched/.deps/libmesos_no_third_party_la-sched.Tpo -c ../../src/sched/sched.cpp
> -fPIC -DPIC -o sched/.libs/libmesos_no_third_party_la-sched.o
> ../third_party/boost-1.37.0/boost/uuid/seed_rng.hpp: In member function 'void
> boost::uuids::detail::seed_rng::sha1_random_digest_()':
> ../third_party/boost-1.37.0/boost/uuid/seed_rng.hpp:153:53: error: ignoring
> return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with
> attribute warn_unused_result [-Werror=unused-result]
> cc1plus: all warnings being treated as errors
> make[2]: *** [sched/libmesos_no_third_party_la-sched.lo] Error 1
> make[2]: Leaving directory `/home/jieyu/workspace/mesos/build/src'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/jieyu/workspace/mesos/build/src'
> make: *** [all-recursive] Error 1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
