git apply --binary <patch_file> I would suggest hanging tight, benh and I will have the patch committed this afternoon.
Sorry for all this trouble, I took on the task of turning on -Wall -Werror on our build. This is an exceptional case where trunk is broken, in general we strive to: -have frequent releases (which you can build from, for a more stable experience) -never have trunk broken (again, this case is not typical and requires a lot of fixes due to the fact that we just turned on compiler warnings for all of our source) On Thu, Aug 30, 2012 at 2:18 PM, Jim Donahue <[email protected]> wrote: > Forgive me, but I'm a real neophyte here. How would one apply this patch? > > Longer term, I've got a script that I use to build new Amazon AMIs when I > need to (hopefully only very very rarely). Right now, I just turn the > crank and do a git clone from git.apache.org/mesos and then build. I > really don't want to start fiddling around with special cases each time I > have to build an AMI. Any advice (other than wait for trunk to get fixed)? > > Jim > > -----Original Message----- > From: Benjamin Mahler [mailto:[email protected]] > Sent: Thursday, August 30, 2012 2:14 PM > To: [email protected] > Subject: Re: [jira] [Commented] (MESOS-264) Make fails on the latest ubuntu > > jim, trunk is broken, the issue you pointed out has been fixed in the patch > file, have you applied it? > > see: https://reviews.apache.org/r/6812/ > > On Thu, Aug 30, 2012 at 2:07 PM, Jim Donahue <[email protected]> wrote: > > > I'm getting a similar error on a clean Amazon Linux image ... It fails > in > > slave/lxc_isolation_module.xpp:206 with an error "comparison between > signed > > and unsigned integer expressions" > > > > Jim Donahue > > > > -----Original Message----- > > From: Thomas Dudziak (JIRA) [mailto:[email protected]] > > Sent: Thursday, August 30, 2012 2:02 PM > > To: [email protected] > > Subject: [jira] [Commented] (MESOS-264) Make fails on the latest ubuntu > > > > > > [ > > > https://issues.apache.org/jira/browse/MESOS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445289#comment-13445289 > ] > > > > Thomas Dudziak commented on MESOS-264: > > -------------------------------------- > > > > That separate patch file works great, but then I get an error during > > compilation: > > > > > > libtool: compile: g++ -DPACKAGE_NAME=\"mesos\" > > -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.9.0\" > > "-DPACKAGE_STRING=\"mesos 0.9.0\"" -DPACKAGE_BUGREPORT=\"\" > > -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"0.9.0\" > -DSTDC_HEADERS=1 > > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 > > -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 > -DHAVE_INTTYPES_H=1 > > -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 > -DLT_OBJDIR=\".libs/\" > > -DHAVE_PTHREAD=1 -DMESOS_HAS_JAVA=1 -DMESOS_HAS_PYTHON=1 -DMESOS_WEBUI=1 > > -I. -Wall -Werror -DMESOS_WEBUI_DIR=\"/usr/share/mesos/webui\" > > -DMESOS_LIBEXECDIR=\"/usr/lib/mesos/mesos\" -I../include > > -I../third_party/libprocess/include -I../include > > -I../third_party/boost-1.51.0 -I../third_party/protobuf-2.4.1/src > > -I../third_party/glog-0.3.1/src > > -I../third_party/zookeeper-3.3.4/src/c/include > > -I../third_party/zookeeper-3.3.4/src/c/generated -pthread -g2 -O2 -c > > slave/process_based_isolation_module.cpp -fPIC -DPIC -o > > slave/.libs/libmesos_no_third_party_la-process_based_isolation_module.o > > slave/process_based_isolation_module.cpp: In member function 'virtual > void > > mesos::internal::slave::ProcessBasedIsolationModule::launchExecutor(const > > mesos::FrameworkID&, const mesos::FrameworkInfo&, const > > mesos::ExecutorInfo&, const string&, const mesos::internal::Resources&)': > > slave/process_based_isolation_module.cpp:113:14: error: ignoring return > > value of 'int pipe(int*)', declared with attribute warn_unused_result > > [-Werror=unused-result] > > cc1plus: all warnings being treated as errors > > make[3]: *** > > [slave/libmesos_no_third_party_la-process_based_isolation_module.lo] > Error 1 > > make[3]: Leaving directory > > `/home/tomdz/projects/open-source/mesos-master/src' > > make[2]: *** [all] Error 2 > > make[2]: Leaving directory > > `/home/tomdz/projects/open-source/mesos-master/src' > > make[1]: *** [all-recursive] Error 1 > > make[1]: Leaving directory > `/home/tomdz/projects/open-source/mesos-master' > > dh_auto_build: make -j1 returned exit code 2 > > make: *** [binary] Error 2 > > > > > > > Make fails on the latest ubuntu > > > ------------------------------- > > > > > > Key: MESOS-264 > > > URL: https://issues.apache.org/jira/browse/MESOS-264 > > > Project: Mesos > > > Issue Type: Bug > > > Components: build > > > Environment: Linux Jie-Ubuntu-VM 3.2.0-29-generic #46-Ubuntu > SMP > > Fri Jul 27 17:03:23 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux > > > g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 > > > Reporter: Jie Yu > > > Assignee: Benjamin Mahler > > > > > > make[2]: Entering directory `/home/jieyu/workspace/mesos/build/src' > > > /bin/bash ../libtool --tag=CXX --mode=compile g++ > > -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" > > -DPACKAGE_VERSION=\"0.9.0\" -DPACKAGE_STRING=\"mesos\ 0.9.0\" > > -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" > > -DVERSION=\"0.9.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 > > -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 > > -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 > -DHAVE_UNISTD_H=1 > > -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 > -DMESOS_HAS_JAVA=1 > > -DMESOS_HAS_PYTHON=1 -DMESOS_WEBUI=1 -I. -I../../src -Wall -Werror > > -DMESOS_WEBUI_DIR=\"/home/jieyu/workspace/mesos/dist/share/mesos/webui\" > > -DMESOS_LIBEXECDIR=\"/home/jieyu/workspace/mesos/dist/libexec/mesos\" > > -I../../include -I../../third_party/libprocess/include -I../include > > -I../third_party/boost-1.37.0 -I../third_party/protobuf-2.4.1/src > > -I../third_party/glog-0.3.1/src > > -I../third_party/zookeeper-3.3.4/src/c/include > > -I../third_party/zookeeper-3.3.4/src/c/generated -pthread -g2 -O2 -MT > > sched/libmesos_no_third_party_la-sched.lo -MD -MP -MF > > sched/.deps/libmesos_no_third_party_la-sched.Tpo -c -o > > sched/libmesos_no_third_party_la-sched.lo `test -f 'sched/sched.cpp' || > > echo '../../src/'`sched/sched.cpp > > > libtool: compile: g++ -DPACKAGE_NAME=\"mesos\" > > -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.9.0\" > > "-DPACKAGE_STRING=\"mesos 0.9.0\"" -DPACKAGE_BUGREPORT=\"\" > > -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"0.9.0\" > -DSTDC_HEADERS=1 > > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 > > -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 > -DHAVE_INTTYPES_H=1 > > -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 > -DLT_OBJDIR=\".libs/\" > > -DHAVE_PTHREAD=1 -DMESOS_HAS_JAVA=1 -DMESOS_HAS_PYTHON=1 -DMESOS_WEBUI=1 > > -I. -I../../src -Wall -Werror > > -DMESOS_WEBUI_DIR=\"/home/jieyu/workspace/mesos/dist/share/mesos/webui\" > > -DMESOS_LIBEXECDIR=\"/home/jieyu/workspace/mesos/dist/libexec/mesos\" > > -I../../include -I../../third_party/libprocess/include -I../include > > -I../third_party/boost-1.37.0 -I../third_party/protobuf-2.4.1/src > > -I../third_party/glog-0.3.1/src > > -I../third_party/zookeeper-3.3.4/src/c/include > > -I../third_party/zookeeper-3.3.4/src/c/generated -pthread -g2 -O2 -MT > > sched/libmesos_no_third_party_la-sched.lo -MD -MP -MF > > sched/.deps/libmesos_no_third_party_la-sched.Tpo -c > > ../../src/sched/sched.cpp -fPIC -DPIC -o > > sched/.libs/libmesos_no_third_party_la-sched.o > > > ../third_party/boost-1.37.0/boost/uuid/seed_rng.hpp: In member function > > 'void boost::uuids::detail::seed_rng::sha1_random_digest_()': > > > ../third_party/boost-1.37.0/boost/uuid/seed_rng.hpp:153:53: error: > > ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', > > declared with attribute warn_unused_result [-Werror=unused-result] > > > cc1plus: all warnings being treated as errors > > > make[2]: *** [sched/libmesos_no_third_party_la-sched.lo] Error 1 > > > make[2]: Leaving directory `/home/jieyu/workspace/mesos/build/src' > > > make[1]: *** [all] Error 2 > > > make[1]: Leaving directory `/home/jieyu/workspace/mesos/build/src' > > > make: *** [all-recursive] Error 1 > > > > -- > > This message is automatically generated by JIRA. > > If you think it was sent incorrectly, please contact your JIRA > > administrators > > For more information on JIRA, see: > http://www.atlassian.com/software/jira > > >
