-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6617/
-----------------------------------------------------------
(Updated Sept. 5, 2012, 10:30 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Changes
-------
Several more changes here..
Files:
-Changed attach from Future<bool> to Future<Nothing>
-Better error messages / responses from file http endpoints
-Debug http endpoint for files to introspect on the attached paths
-Master / Slave now check result of the attach (using defer)
Misc:
-Deleted libprocess/src/tokenize.{hpp,cpp} and moved tokenize into
stout/strings.hpp
-strings::split did not allow empties! (caused a bug in file resolution) Fixed
this and adjusted all callers relying on empties to use tokenize() instead.
-Adjusted the tests for tokenize() and split() in stout_tests.cpp
This change is getting gigantic.. may have to sit down and pair with benh to
get this in.
NOTE: This does not fix the issues on local runs (master/slave hardcode the log
filename, on local it's different: mesos-master.INFO -> mesos-local.INFO)
Glog does not allow retrieving the filename:
http://code.google.com/p/google-glog/issues/detail?id=116
Description
-------
Implementing the file abstraction and http endpoints for file reading /
browsing.
This addresses bug MESOS-255.
https://issues.apache.org/jira/browse/MESOS-255
Diffs (updated)
-----
src/Makefile.am 19bd20d
src/common/attributes.cpp 66d0b70
src/common/resources.cpp 2cee743
src/common/values.cpp ec341be
src/configurator/configuration.hpp e2cd1b5
src/configurator/configurator.cpp 3916427
src/files/files.hpp d0cab91
src/files/files.cpp d4080d4
src/launcher/main.cpp 06597e6
src/linux/cgroups.cpp 9cedea5
src/logging/logging.cpp 6909b0b
src/master/http.cpp c480bc6
src/master/master.hpp 866f3ef
src/master/master.cpp ab516ec
src/master/slaves_manager.cpp e25efd0
src/slave/http.cpp a1f7926
src/slave/slave.hpp b7ab2ab
src/slave/slave.cpp ced232d
src/tests/configurator_tests.cpp c2f5aa0
src/tests/files_tests.cpp PRE-CREATION
src/tests/stout_tests.cpp 0bc60a9
src/tests/utils.hpp 54da799
src/webui/master/static/controllers.js 1606e64
third_party/libprocess/Makefile.am f898469
third_party/libprocess/include/process/http.hpp 8424ca6
third_party/libprocess/include/process/io.hpp 6a40b18
third_party/libprocess/include/stout/hashmap.hpp 51bdea0
third_party/libprocess/include/stout/json.hpp 25dbcf4
third_party/libprocess/include/stout/os.hpp df0f7ff
third_party/libprocess/include/stout/path.hpp 80d9bc6
third_party/libprocess/include/stout/stringify.hpp ad2f2fa
third_party/libprocess/include/stout/strings.hpp 0646bf9
third_party/libprocess/src/decoder.hpp 105fe5d
third_party/libprocess/src/encoder.hpp 55b5d50
third_party/libprocess/src/process.cpp 2b2d521
third_party/libprocess/src/statistics.cpp d05b327
third_party/libprocess/src/tokenize.hpp f886186
third_party/libprocess/src/tokenize.cpp 759ce5f
Diff: https://reviews.apache.org/r/6617/diff/
Testing
-------
Added files_tests.cpp
make check
Thanks,
Ben Mahler
