> On Sept. 5, 2012, 11:52 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 310 > > <https://reviews.apache.org/r/6617/diff/4-6/?file=145099#file145099line310> > > > > s/slsave/slave/
nice catch, thanks > On Sept. 5, 2012, 11:52 p.m., Vinod Kone wrote: > > src/files/files.hpp, line 53 > > <https://reviews.apache.org/r/6617/diff/4-6/?file=145093#file145093line53> > > > > woah.. Nothing! sweet. How hard is it to actually extend Future to be > > parametrized by void. > > I think Future<void> would be awesome to have. Has to be done by template specialization, and based on the size of future.hpp, I think we can agree against it ;) Benh and I were discussing this though, and I think he preferred making a Void type to replace Nothing. I think I prefer that as well but hesitant to refactor even more code in this CL. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6617/#review11075 ----------------------------------------------------------- On Sept. 6, 2012, 12:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6617/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2012, 12:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu. > > > Description > ------- > > Implementing the file abstraction and http endpoints for file reading / > browsing. > > > This addresses bug MESOS-255. > https://issues.apache.org/jira/browse/MESOS-255 > > > Diffs > ----- > > src/Makefile.am 19bd20d > src/common/attributes.cpp 66d0b70 > src/common/resources.cpp 2cee743 > src/common/values.cpp ec341be > src/configurator/configuration.hpp e2cd1b5 > src/configurator/configurator.cpp 3916427 > src/files/files.hpp d0cab91 > src/files/files.cpp d4080d4 > src/launcher/main.cpp 06597e6 > src/linux/cgroups.cpp 9cedea5 > src/logging/logging.cpp 6909b0b > src/master/http.cpp c480bc6 > src/master/master.hpp 866f3ef > src/master/master.cpp ab516ec > src/master/slaves_manager.cpp e25efd0 > src/slave/http.cpp a1f7926 > src/slave/slave.hpp b7ab2ab > src/slave/slave.cpp ced232d > src/tests/configurator_tests.cpp c2f5aa0 > src/tests/files_tests.cpp PRE-CREATION > src/tests/stout_tests.cpp 0bc60a9 > src/tests/utils.hpp 54da799 > src/webui/master/static/controllers.js 1606e64 > third_party/libprocess/Makefile.am f898469 > third_party/libprocess/include/process/http.hpp 8424ca6 > third_party/libprocess/include/process/io.hpp 6a40b18 > third_party/libprocess/include/stout/hashmap.hpp 51bdea0 > third_party/libprocess/include/stout/json.hpp 25dbcf4 > third_party/libprocess/include/stout/os.hpp df0f7ff > third_party/libprocess/include/stout/path.hpp 80d9bc6 > third_party/libprocess/include/stout/stringify.hpp ad2f2fa > third_party/libprocess/include/stout/strings.hpp 0646bf9 > third_party/libprocess/src/decoder.hpp 105fe5d > third_party/libprocess/src/encoder.hpp 55b5d50 > third_party/libprocess/src/process.cpp 2b2d521 > third_party/libprocess/src/statistics.cpp d05b327 > third_party/libprocess/src/tokenize.hpp f886186 > third_party/libprocess/src/tokenize.cpp 759ce5f > > Diff: https://reviews.apache.org/r/6617/diff/ > > > Testing > ------- > > Added files_tests.cpp > make check > > > Thanks, > > Ben Mahler > >
