> On Sept. 8, 2012, 4:45 p.m., Benjamin Hindman wrote: > > src/files/files.hpp, lines 60-62 > > <https://reviews.apache.org/r/6617/diff/9/?file=151409#file151409line60> > > > > s/upid/pid/g > > > > In the future, we'll eliminate UPID and just use PID<> when we don't > > know the type and PID<T> when we do. > > Ben Mahler wrote: > in this case I used PID<> since I don't want to expose FilesProcess, just > double checking that's what you wanted?
Yup! > On Sept. 8, 2012, 4:45 p.m., Benjamin Hindman wrote: > > third_party/libprocess/src/process.cpp, line 3144 > > <https://reviews.apache.org/r/6617/diff/9/?file=151448#file151448line3144> > > > > Please add the following at the end of this line: > > > > // TODO(benh): Remove 'const &' after fixing libprocess. > > Ben Mahler wrote: > done, lost me on this one..? Normally you wouldn't need to make a primitive like size_t be const &, but in this case I only have Future::then versions for arguments that are const &, so that's why it has to be const &. This is a bug on my side. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6617/#review11205 ----------------------------------------------------------- On Sept. 9, 2012, 4:12 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6617/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2012, 4:12 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu. > > > Description > ------- > > Implementing the file abstraction and http endpoints for file reading / > browsing. > > > This addresses bug MESOS-255. > https://issues.apache.org/jira/browse/MESOS-255 > > > Diffs > ----- > > src/Makefile.am 19bd20d > src/common/attributes.cpp 66d0b70 > src/common/resources.cpp 2cee743 > src/common/values.cpp ec341be > src/configurator/configuration.hpp e2cd1b5 > src/configurator/configurator.cpp 3916427 > src/files/files.hpp d0cab91 > src/files/files.cpp d4080d4 > src/launcher/main.cpp 06597e6 > src/linux/cgroups.cpp 9cedea5 > src/local/local.cpp 9c1c5b6 > src/logging/logging.cpp 6909b0b > src/master/http.cpp c480bc6 > src/master/main.cpp 48859f1 > src/master/master.hpp 866f3ef > src/master/master.cpp ab516ec > src/master/slaves_manager.cpp e25efd0 > src/slave/http.cpp a1f7926 > src/slave/main.cpp f1aade2 > src/slave/slave.hpp b7ab2ab > src/slave/slave.cpp ced232d > src/tests/allocator_tests.cpp 80ba39d > src/tests/allocator_zookeeper_tests.cpp c4956dc > src/tests/configurator_tests.cpp c2f5aa0 > src/tests/fault_tolerance_tests.cpp 0e88701 > src/tests/files_tests.cpp PRE-CREATION > src/tests/gc_tests.cpp 66bdbb2 > src/tests/master_detector_tests.cpp 5b2ab4f > src/tests/master_tests.cpp c77a4ed > src/tests/resource_offers_tests.cpp 1d7d9ed > src/tests/stout_tests.cpp 0bc60a9 > src/tests/utils.hpp 54da799 > src/webui/master/static/controllers.js 1606e64 > third_party/libprocess/Makefile.am f898469 > third_party/libprocess/include/process/http.hpp 8424ca6 > third_party/libprocess/include/process/io.hpp 6a40b18 > third_party/libprocess/include/process/nothing.hpp c11a010 > third_party/libprocess/include/process/once.hpp 46be55c > third_party/libprocess/include/process/pid.hpp 6a2eec9 > third_party/libprocess/include/stout/hashmap.hpp 51bdea0 > third_party/libprocess/include/stout/json.hpp 25dbcf4 > third_party/libprocess/include/stout/nothing.hpp PRE-CREATION > third_party/libprocess/include/stout/numify.hpp ffd83ae > third_party/libprocess/include/stout/os.hpp df0f7ff > third_party/libprocess/include/stout/path.hpp 80d9bc6 > third_party/libprocess/include/stout/stringify.hpp ad2f2fa > third_party/libprocess/include/stout/strings.hpp 0646bf9 > third_party/libprocess/src/decoder.hpp 105fe5d > third_party/libprocess/src/encoder.hpp 55b5d50 > third_party/libprocess/src/process.cpp 2b2d521 > third_party/libprocess/src/statistics.cpp d05b327 > third_party/libprocess/src/tokenize.hpp f886186 > third_party/libprocess/src/tokenize.cpp 759ce5f > > Diff: https://reviews.apache.org/r/6617/diff/ > > > Testing > ------- > > Added files_tests.cpp > make check > > > Thanks, > > Ben Mahler > >
