----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7138/#review11638 -----------------------------------------------------------
Ship it! third_party/libprocess/include/process/collect.hpp <https://reviews.apache.org/r/7138/#comment25143> why can't you use non_const iterator, instead of making a copy below? - Vinod Kone On Sept. 17, 2012, 10:54 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7138/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 10:54 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 53d611f > src/log/network.hpp 616a397 > src/master/master.cpp addabdb > src/slave/cgroups_isolation_module.cpp e0289b2 > src/slave/slave.cpp b85f954 > third_party/libprocess/examples/example.cpp 599dec4 > third_party/libprocess/include/process/collect.hpp f01389e > third_party/libprocess/include/process/future.hpp 584a7d3 > third_party/libprocess/include/process/protobuf.hpp 5911c59 > third_party/libprocess/src/process.cpp d5bee23 > third_party/libprocess/src/tests.cpp aa5e396 > > Diff: https://reviews.apache.org/r/7138/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
