----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7138/#review11661 -----------------------------------------------------------
Ship it! API wise, looks good, I actually noticed the frustration from the previous onAny in my pending files download CL! As for the changes to the future / process logic, looks good AFAICT. third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7138/#comment25190> just as an aside, on timeout, what happens to the guy performing the work for the request? Let's say for files, will my callback not be executed because the future got discarded? It's probably best that we discuss this offline though :) third_party/libprocess/src/tests.cpp <https://reviews.apache.org/r/7138/#comment25188> this doesn't really test that the onAny is actually called - Ben Mahler On Sept. 17, 2012, 10:54 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7138/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 10:54 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 53d611f > src/log/network.hpp 616a397 > src/master/master.cpp addabdb > src/slave/cgroups_isolation_module.cpp e0289b2 > src/slave/slave.cpp b85f954 > third_party/libprocess/examples/example.cpp 599dec4 > third_party/libprocess/include/process/collect.hpp f01389e > third_party/libprocess/include/process/future.hpp 584a7d3 > third_party/libprocess/include/process/protobuf.hpp 5911c59 > third_party/libprocess/src/process.cpp d5bee23 > third_party/libprocess/src/tests.cpp aa5e396 > > Diff: https://reviews.apache.org/r/7138/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
