----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7138/#review12338 -----------------------------------------------------------
Ship it! third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7138/#comment26117> Perhaps for another review, but since we're pre-C++11, is there anything stopping us from using boost's weak_ptr for these TODOs? - Ben Mahler On Oct. 11, 2012, 7:34 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7138/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 7:34 a.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 714d73f7e4de0d63ee5b50539799fbd7c2a5b57e > src/log/network.hpp 616a3979a7dc5c9713d064205aa7a146dfdc72d1 > src/master/master.cpp b81488844e4a84482ff3b1c3f068b9a979558184 > src/slave/cgroups_isolation_module.cpp > 28251ac760437ddadd7c3578aacc34e9c124e469 > src/slave/slave.cpp 752cc71771ec84632d1c92c1718a1f7437e96298 > third_party/libprocess/examples/example.cpp > 599dec439be311be2299a33da1d9b98005ed384a > third_party/libprocess/include/process/collect.hpp > f01389e7788debcd2e7815b71b98d02791ae5bbe > third_party/libprocess/include/process/future.hpp > c768c2e7bf89f6b9e010e833642f6d86ef0cba4e > third_party/libprocess/include/process/protobuf.hpp > 5911c5966d8cdd1cdce6fad33a306abc15476f50 > third_party/libprocess/src/process.cpp > fde7154f9a4432acaff09849c0fa69c0694c9834 > third_party/libprocess/src/tests.cpp > 1cb26cd1729ce1cf0ed9573d3eb40690705d4b4e > > Diff: https://reviews.apache.org/r/7138/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
