> On Sept. 26, 2012, 8:05 p.m., Ben Mahler wrote: > > src/detector/detector.cpp, line 374 > > <https://reviews.apache.org/r/7289/diff/1/?file=160208#file160208line374> > > > > I think this comment is more readable in numbered form: > > > > // Three scenarios are possible here: > > // 1. We were the master and we're still the master (because we > > haven't yet gotten a session expiration). > > // 2. Someone else was the master and they're still the master. > > // 3. Someone else was the master and someone else still is now the > > master. > > // Either way, run the leader detector. > > > > Run the leader detector to pick up the new leader regardless..?
I slightly changed the comment in a subsequent review so I'll make these changes there. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7289/#review11936 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7289/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (1 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > > Diff: https://reviews.apache.org/r/7289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
