> On Sept. 26, 2012, 9:44 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 399 > > <https://reviews.apache.org/r/7289/diff/1/?file=160208#file160208line399> > > > > This does a read after every reconnect. This is just the masters which > > is a small population of nodes, but fwict this larger bug fix does not > > require this read pounding. In the end you should only need to > > detectMaster() after the local timer code (not in this CL) expires your > > session pro-actively.
This always did a read after every reconnect. I agree that presumably this is unnecessary due to the watcher being in place, but I'd prefer not to make that change right now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7289/#review11952 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7289/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (1 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > > Diff: https://reviews.apache.org/r/7289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
