> On Oct. 8, 2012, 7:39 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/net.hpp, line 50 > > <https://reviews.apache.org/r/7454/diff/2/?file=174758#file174758line50> > > > > Feel free to punt, but eventually we'd likely want fdopen, fclose > > wrappers in stout/fs.hpp.
i will punt for now. this review is already encompassing more than what it was intended to. > On Oct. 8, 2012, 7:39 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/net.hpp, line 35 > > <https://reviews.apache.org/r/7454/diff/2/?file=174758#file174758line35> > > > > Ok now we can just return fd directly since it's a Try<int> with the > > appropriate error, right? > > > > This convention works if we've augmented all of our os Try::error > > strings in os, but I could be convinced otherwise :) fixed - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7454/#review12238 ----------------------------------------------------------- On Oct. 8, 2012, 7:27 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7454/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 7:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Better error messages > > > Fix for curl download > > > Diffs > ----- > > src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee > third_party/libprocess/include/stout/net.hpp > f6b770c8ca7d21e0aca0f614168a0985c77046b0 > third_party/libprocess/include/stout/os.hpp > 13dbc715ed08cfe6b24ee20744d427dac1104694 > > Diff: https://reviews.apache.org/r/7454/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Vinod Kone > >
