----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7454/#review12277 -----------------------------------------------------------
I just tried to apply the patch from this review and compile failed - haven't had a chance to dig yet but it seems related: \" -DBUILD_DIR=\"/srv/mesos/src/build\" -I../third_party/gmock-1.6.0/gtest/include -I../third_party/gmock-1.6.0/include -I/usr/lib/jvm/java-7-oracle/include -I/usr/lib/jvm/java-7-oracle/include/linux -DZOOKEEPER_VERSION=\"3.3.4\" -pthread -g2 -O2 -MT tests/mesos_tests-stout_tests.o -MD -MP -MF tests/.deps/mesos_tests-stout_tests.Tpo -c -o tests/mesos_tests-stout_tests.o `test -f 'tests/stout_tests.cpp' || echo '/srv/mesos/src/src/'`tests/stout_tests.cpp /srv/mesos/src/src/tests/stout_tests.cpp: In member function 'virtual void StoutUtilsTest_rmdir_Test::TestBody()': /srv/mesos/src/src/tests/stout_tests.cpp:316:30: error: uninitialized const 'EMPTY' [-fpermissive] /srv/mesos/src/third_party/libprocess/include/stout/hashset.hpp:17:7: note: 'const class hashset<std::basic_string<char> >' has no user-provided default constructor make[3]: *** [tests/mesos_tests-stout_tests.o] Error 1 make[3]: Leaving directory `/srv/mesos/src/build/src' make[2]: *** [check-am] Error 2 make[2]: Leaving directory `/srv/mesos/src/build/src' make[1]: *** [check] Error 2 make[1]: Leaving directory `/srv/mesos/src/build/src' make: *** [check-recursive] Error 1 run-parts: /var/lib/cloud/instance/scripts/part-018 exited with return code 2 - Florian Leibert On Oct. 8, 2012, 7:54 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7454/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 7:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Better error messages > > > Fix for curl download > > > Diffs > ----- > > src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee > third_party/libprocess/include/stout/net.hpp > f6b770c8ca7d21e0aca0f614168a0985c77046b0 > third_party/libprocess/include/stout/os.hpp > 13dbc715ed08cfe6b24ee20744d427dac1104694 > > Diff: https://reviews.apache.org/r/7454/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Vinod Kone > >
