----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8681/#review14723 -----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment31227> why did you change this one? you only want to use lstat when looking at st_mode or st_size: "For symbolic links, the st_mode member shall contain meaningful information when used with the file type macros, and the st_size member shall contain the length of the pathname contained in the symbolic link. File mode bits and the contents of the remaining members of the stat structure are unspecified." But: "According to POSIX.1-2001, lstat() on a symbolic link need return valid information only in the st_size field and the file-type component of the st_mode field of the stat structure. POSIX.-2008 tightens the specification, requiring lstat() to return valid information in all fields except the permission bits in st_mode." Maybe add a note or? - Ben Mahler On Dec. 19, 2012, 4:37 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8681/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 4:37 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Needed this for my next review. > > > Diffs > ----- > > third_party/libprocess/include/stout/os.hpp > 76e5e0624af36a0021755fb4acf7f76bfb81a823 > > Diff: https://reviews.apache.org/r/8681/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
