----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8681/#review16551 -----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment35122> What's the justification for changing this one? I don't really have objections, but I'd like to understand the thought behind this third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment35123> Here I'm not sure what to do either.. I feel like the caller would need to know the semantics they want in terms of links. - Ben Mahler On Jan. 28, 2013, 4:29 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8681/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 4:29 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Needed this for my next review. > > > Diffs > ----- > > third_party/libprocess/include/stout/os.hpp > fdba9cadc38251b192e9d395a0a1ab1f08327596 > > Diff: https://reviews.apache.org/r/8681/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
