----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8681/#review15558 -----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment33585> Okay, so if this is a link to a directory, it will now return false ... are those the semantics we want? WDPD? third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment33586> Ditto above. third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment33587> Yeah, definitely want this one to be lstat. third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/8681/#comment33588> This one makes me suspicious ... what do other libraries do? - Benjamin Hindman On Dec. 19, 2012, 6:03 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8681/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 6:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Needed this for my next review. > > > Diffs > ----- > > third_party/libprocess/include/stout/os.hpp > 76e5e0624af36a0021755fb4acf7f76bfb81a823 > > Diff: https://reviews.apache.org/r/8681/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
