----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9092/#review15764 -----------------------------------------------------------
third_party/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/9092/#comment33928> s/, they/. They/ third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33929> Put the initializer list on its own line. third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33932> This should probably also hold its type? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33930> Initializer on a different line. Also, I didn't realize (expect) Seconds to take a -ve value!? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33931> Why virtual? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33934> Its useful to explain what the mapping is. Same, for the above map. third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33936> s/for existing meter/for an existing meter that matches the meteredName and meteredType/ third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33933> What if meterType doesn't match? As I mentioned above, meter->value() would be useful to have. third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33937> was this necessary to suppress gcc warning? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9092/#comment33935> Is there any way you can ensure that meteredName doesn't conflict with a stat name? - Vinod Kone On Jan. 24, 2013, 9:11 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9092/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 9:11 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This add metering into the statistics model. The metering was inspired by > jie's monitoring reviews. > > We'll need to compute metered data on top incoming raw data. The challenge is > that some meters will require previous data: > For example: > 1. cpu_time = 10 @ time 10; > 2. cpu_time = 20 @ time 20; --> cpu_usage = 1.0 (100%) this is 20-10 / 20-10 > 3. cpu_time = 25 @ time 30; --> cpu_usage = 0.5 (50%) this is 25-20 / 30-20 > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > > Diff: https://reviews.apache.org/r/9092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
