----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9093/#review15767 -----------------------------------------------------------
third_party/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/9093/#comment33938> s/sparsifying/aggregating/ ? third_party/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/9093/#comment33939> s/oldest/older/ third_party/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/9093/#comment33940> s/two/three/ :) third_party/libprocess/include/process/statistics.hpp <https://reviews.apache.org/r/9093/#comment33941> s/for/associated with/ third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment33943> unless it is archived? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment33942> An explanation for this mapping would be great. third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment33944> pull the 5 minutes out as a constant. also, doc this behavior in its declaration - Vinod Kone On Jan. 24, 2013, 11:19 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9093/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 11:19 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Some statistics will be ephemeral. (e.g. executor resource usage information). > It does not make sense to keep a value of these stats in the snapshot. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > > Diff: https://reviews.apache.org/r/9093/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
