> On Jan. 28, 2013, 8:44 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/statistics.hpp, line 26 > > <https://reviews.apache.org/r/9093/diff/2/?file=251833#file251833line26> > > > > s/sparsifying/aggregating/ ?
What I mean here is instead of always deleting the oldest value, we would sparsify older values. E.g. Within 1 minute ago: Keep all values Within 1-2 minutes ago: Keep half the values Within 2-4 minutes ago: Keep 1/4 the values Within 4-8 minutes ago: Keep 1/8 the values etc.. There are many techniques for sparsifying the older values, I'm not sure which would be best as of yet. > On Jan. 28, 2013, 8:44 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/statistics.hpp, line 27 > > <https://reviews.apache.org/r/9093/diff/2/?file=251833#file251833line27> > > > > s/oldest/older/ Indeed I mean oldest. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9093/#review15767 ----------------------------------------------------------- On Jan. 24, 2013, 11:19 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9093/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 11:19 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Some statistics will be ephemeral. (e.g. executor resource usage information). > It does not make sense to keep a value of these stats in the snapshot. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > > Diff: https://reviews.apache.org/r/9093/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
