----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9174/#review15950 -----------------------------------------------------------
hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34242> space after # hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34243> Why did you need to specify this file? Seems like this could be brittle for people with different setups, no? -Dreactor.repo=file://$HOME/.m2/repository hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34246> Do you know why we have to set this? If .m2 does not exist, will it create it? hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34247> Seems better now that we have logic for the summary, to just build the summary by appending to a list or string as we execute commands. That way, the summary won't get out of sync with what we're actually executing. Up to you. hadoop/hadoop-7698-1.patch <https://reviews.apache.org/r/9174/#comment34248> Can you add a comment for this? i.e. looks like this is just to deduce the os_name for a url. hadoop/hadoop-gridmix.patch <https://reviews.apache.org/r/9174/#comment34250> How did this work before you fixed the patch numbers?? - Ben Mahler On Jan. 31, 2013, 8:42 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9174/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 8:42 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See Summary. > > Also, we only run 'ant' once instead of twice. > > > Diffs > ----- > > hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 > hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION > hadoop/hadoop-7698-1.patch PRE-CREATION > hadoop/hadoop-gridmix.patch 903ff19d2278f09136a495919ea13062871970ad > > Diff: https://reviews.apache.org/r/9174/diff/ > > > Testing > ------- > > make hadoop-2.0.0-mr1-cdh4.1.2 > make hadoop-0.20.2-cdh3u3 > make hadoop-0.20.205.0 > > > Thanks, > > Vinod Kone > >
