> On Jan. 31, 2013, 6:57 p.m., Ben Mahler wrote: > > hadoop/hadoop-7698-1.patch, line 9 > > <https://reviews.apache.org/r/9174/diff/2/?file=253802#file253802line9> > > > > Can you add a comment for this? > > > > i.e. looks like this is just to deduce the os_name for a url.
This patch is downloaded, as is, from the Hadoop Jira (link in README). I prefer not to add it. Let me know if the explanation in the Jira isn't clear enough. > On Jan. 31, 2013, 6:57 p.m., Ben Mahler wrote: > > hadoop/hadoop-gridmix.patch, line 5 > > <https://reviews.apache.org/r/9174/diff/2/?file=253803#file253803line5> > > > > How did this work before you fixed the patch numbers?? I'm as baffled as you here, on how it worked before. FWIW, the current range is correct. The # after the comma indicates number of lines (removed and un-edited) for the original file, and number of lines (added and un-edited) for the new file. > On Jan. 31, 2013, 6:57 p.m., Ben Mahler wrote: > > hadoop/TUTORIAL.sh, line 529 > > <https://reviews.apache.org/r/9174/diff/2/?file=253799#file253799line529> > > > > Why did you need to specify this file? Seems like this could be brittle > > for people with different setups, no? > > > > -Dreactor.repo=file://$HOME/.m2/repository I don't know enough about ant/Maven, but this link http://maven.apache.org/guides/mini/guide-multiple-modules.html suggests its a Maven component that is responsible for managing multi-module projects. For me, ant build fails due to some unresolved ivy dependencies (junit,jetty etc). FWIW, the cloudera build script (cloudera/do-release-build) sets that argument when building CDH. I would have loved to just use that script, but even that script is broken in several ways :/ Also, "$HOME/.m2" is default maven repository location and gets created if its not present. > On Jan. 31, 2013, 6:57 p.m., Ben Mahler wrote: > > hadoop/TUTORIAL.sh, line 554 > > <https://reviews.apache.org/r/9174/diff/2/?file=253799#file253799line554> > > > > Do you know why we have to set this? > > > > If .m2 does not exist, will it create it? See above. > On Jan. 31, 2013, 6:57 p.m., Ben Mahler wrote: > > hadoop/TUTORIAL.sh, line 646 > > <https://reviews.apache.org/r/9174/diff/2/?file=253799#file253799line646> > > > > Seems better now that we have logic for the summary, to just build the > > summary by appending to a list or string as we execute commands. > > > > That way, the summary won't get out of sync with what we're actually > > executing. Up to you. OK. Fixed. All commands are run via a function called "run" that does error checking and appends to summary! Thanks for the nudge. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9174/#review15950 ----------------------------------------------------------- On Jan. 31, 2013, 8:42 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9174/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 8:42 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See Summary. > > Also, we only run 'ant' once instead of twice. > > > Diffs > ----- > > hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 > hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION > hadoop/hadoop-7698-1.patch PRE-CREATION > hadoop/hadoop-gridmix.patch 903ff19d2278f09136a495919ea13062871970ad > > Diff: https://reviews.apache.org/r/9174/diff/ > > > Testing > ------- > > make hadoop-2.0.0-mr1-cdh4.1.2 > make hadoop-0.20.2-cdh3u3 > make hadoop-0.20.205.0 > > > Thanks, > > Vinod Kone > >
