----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9174/#review16445 -----------------------------------------------------------
hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34939> Oh come on, throw me a bone! s/cmd/command/ ;) hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34936> Why not test for !=0 and then set summary always at the bottom of the function? hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34938> I love the run function, but you've changed the semantics of the tutorial. We used to show people what we were about to execute and let them decide to continue or not. Now we ask them if we should continue, then show them what we're going to execute, and run it. Did you know you were changing these semantics? What's your reasoning here? hadoop/TUTORIAL.sh <https://reviews.apache.org/r/9174/#comment34934> Indenting this looks weird (and only doesn't wreak havoc with your output because the first line is empty!). - Benjamin Hindman On Feb. 11, 2013, 7:18 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9174/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2013, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See Summary. > > Also, we only run 'ant' once instead of twice. > > > Diffs > ----- > > hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 > hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/9174/diff/ > > > Testing > ------- > > make hadoop-2.0.0-mr1-cdh4.1.2 > make hadoop-0.20.2-cdh3u3 > make hadoop-0.20.205.0 > > > Thanks, > > Vinod Kone > >
