----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9304/#review16132 -----------------------------------------------------------
src/tests/stout_tests.cpp <https://reviews.apache.org/r/9304/#comment34485> It's a bit unfortunate that error.hpp and none.hpp have to be included to be used, despite being tied so closely with try.hpp, result.hpp, and option.hpp. src/tests/stout_tests.cpp <https://reviews.apache.org/r/9304/#comment34483> No similar tests for Option? third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34484> Is there a reason for using a line-width of 70 for comments? Are we not universally using 80? Ditto for none.hpp third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34486> explicit? third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34487> Can you give an example here? Are the nested cases in your stout_tests? Ditto for none.hpp - Ben Mahler On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9304/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 5:57 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/stout_tests.cpp fffef3e42774e9b090a098a219a92e642d303d27 > third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 > third_party/libprocess/include/stout/error.hpp PRE-CREATION > third_party/libprocess/include/stout/none.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/9304/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
