> On Feb. 5, 2013, 7:36 p.m., Ben Mahler wrote: > > src/tests/stout_tests.cpp, line 10 > > <https://reviews.apache.org/r/9304/diff/1/?file=255488#file255488line10> > > > > It's a bit unfortunate that error.hpp and none.hpp have to be included > > to be used, despite being tied so closely with try.hpp, result.hpp, and > > option.hpp.
Let's consider adding some aggregating headers like "functional.hpp" which includes all that's necessary. > On Feb. 5, 2013, 7:36 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/error.hpp, line 31 > > <https://reviews.apache.org/r/9304/diff/1/?file=255490#file255490line31> > > > > Can you give an example here? > > Are the nested cases in your stout_tests? > > > > Ditto for none.hpp Added an example in the comment. > On Feb. 5, 2013, 7:36 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/error.hpp, line 23 > > <https://reviews.apache.org/r/9304/diff/1/?file=255490#file255490line23> > > > > explicit? Great idea! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9304/#review16132 ----------------------------------------------------------- On Feb. 8, 2013, 5:48 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9304/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 5:48 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/stout_tests.cpp fffef3e42774e9b090a098a219a92e642d303d27 > third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 > third_party/libprocess/include/stout/error.hpp PRE-CREATION > third_party/libprocess/include/stout/none.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/9304/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
