----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9304/#review16142 -----------------------------------------------------------
src/tests/stout_tests.cpp <https://reviews.apache.org/r/9304/#comment34532> using std::string at the top and just use string everywhere. src/tests/stout_tests.cpp <https://reviews.apache.org/r/9304/#comment34535> Missing an EXPECT here? EXPECT_TRUE(t.isError()); src/tests/stout_tests.cpp <https://reviews.apache.org/r/9304/#comment34539> Missing expectation again? third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34541> s/implicitely/implicitly/ s/convertable/convertible/ third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34543> You shouldn't use "of course" and "probably" (3 times) in the same sentence :) The former indicates you are confident, the latter indicates you are not. s/Of course, performance/Performance/ third_party/libprocess/include/stout/error.hpp <https://reviews.apache.org/r/9304/#comment34544> same here..i'm confused. third_party/libprocess/include/stout/none.hpp <https://reviews.apache.org/r/9304/#comment34546> s/implicitely/implicitly/ s/covertable/convertible/ third_party/libprocess/include/stout/none.hpp <https://reviews.apache.org/r/9304/#comment34547> s/fields/fields,/ - Vinod Kone On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9304/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 5:57 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/stout_tests.cpp fffef3e42774e9b090a098a219a92e642d303d27 > third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325 > third_party/libprocess/include/stout/error.hpp PRE-CREATION > third_party/libprocess/include/stout/none.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/9304/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
