----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9320/#review16217 -----------------------------------------------------------
src/python/native/proxy_scheduler.cpp <https://reviews.apache.org/r/9320/#comment34651> Could you add a reason in a comment next to the include, indicating that this header has to be the top most include? Something along the lines of, #include <Python.h> # This header file has to be at the top. - Vinod Kone On Feb. 6, 2013, 4:34 a.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9320/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 4:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Python.h is a finicky header file. Include it before iostream. > > > This addresses bug MESOS-271. > https://issues.apache.org/jira/browse/MESOS-271 > > > Diffs > ----- > > src/python/native/proxy_scheduler.cpp 8bf368d > > Diff: https://reviews.apache.org/r/9320/diff/ > > > Testing > ------- > > make check passes. > > > Thanks, > > David Mackey > >
