----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9320/#review16225 -----------------------------------------------------------
src/python/native/proxy_scheduler.cpp <https://reviews.apache.org/r/9320/#comment34676> Also, forgot to mention that we intersperse groups of includes with new lines. The convention is as follows <c-standard-headers> <thirdparty c headers> <c++-standard-headers> <thirdparty c++ headers> "mesos headers" NOTE: We further split a group according to the depth of the header path. Example: #include <errno.h> #include <fts.h> #include <signal.h> #include <unistd.h> #include <sys/syscall.h> #include <sys/types.h> #include <glog/logging.h> #include <fstream> #include <list> #include <map> #include <set> #include <sstream> #include <string> #include <vector> #include <process/collect.hpp> #include <process/defer.hpp> #include <process/delay.hpp> #include <process/io.hpp> #include <process/process.hpp> #include <stout/duration.hpp> #include <stout/foreach.hpp> #include <stout/lambda.hpp> #include <stout/option.hpp> #include <stout/os.hpp> #include <stout/path.hpp> #include <stout/stringify.hpp> #include <stout/strings.hpp> #include "linux/cgroups.hpp" #include "linux/fs.hpp" #include "linux/proc.hpp" Let me know if you have any questions about this! - Vinod Kone On Feb. 6, 2013, 4:34 a.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9320/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 4:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Python.h is a finicky header file. Include it before iostream. > > > This addresses bug MESOS-271. > https://issues.apache.org/jira/browse/MESOS-271 > > > Diffs > ----- > > src/python/native/proxy_scheduler.cpp 8bf368d > > Diff: https://reviews.apache.org/r/9320/diff/ > > > Testing > ------- > > make check passes. > > > Thanks, > > David Mackey > >
