----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9320/#review16242 -----------------------------------------------------------
src/python/native/proxy_executor.cpp <https://reviews.apache.org/r/9320/#comment34693> We've done this in other places as well, and IIRC this related to the redefinition of _POSIX_C_SOURCE? If so, can you update the comment to include a relevant link: // Must be included before standard headers. // See: http://docs.python.org/2/c-api/intro.html#include-files #include <Python.h> Also, can you update the other spots to include the comment: src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.cpp src/python/native/module.hpp - Ben Mahler On Feb. 7, 2013, 1:06 a.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9320/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 1:06 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Python.h is a finicky header file. Include it before iostream. > > Relevant documentation: > http://docs.python.org/2/c-api/intro.html#include-files > > > This addresses bug MESOS-271. > https://issues.apache.org/jira/browse/MESOS-271 > > > Diffs > ----- > > src/python/native/proxy_executor.cpp 2767e0a > src/python/native/proxy_scheduler.cpp 8bf368d > > Diff: https://reviews.apache.org/r/9320/diff/ > > > Testing > ------- > > make check passes. > > > Thanks, > > David Mackey > >
