-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9092/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 11:14 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
-benh review.
-Added stout/owned.hpp to abstract away unique ownership.
Description
-------
This add metering into the statistics model. The metering was inspired by jie's
monitoring reviews.
We'll need to compute metered data on top incoming raw data. The challenge is
that some meters will require previous data:
For example:
1. cpu_time = 10 @ time 10;
2. cpu_time = 20 @ time 20; --> cpu_usage = 1.0 (100%) this is 20-10 / 20-10
3. cpu_time = 25 @ time 30; --> cpu_usage = 0.5 (50%) this is 25-20 / 30-20
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs (updated)
-----
third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325
third_party/libprocess/include/process/statistics.hpp
9e3041a6e2a8ef022eacacad00bc4d974a8e33c9
third_party/libprocess/include/stout/owned.hpp PRE-CREATION
third_party/libprocess/src/statistics.cpp
2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f
third_party/libprocess/src/tests/statistics_tests.cpp
0aaab3526618171c7cfbd11d40d614344bcbfd0a
Diff: https://reviews.apache.org/r/9092/diff/
Testing
-------
make check
Thanks,
Ben Mahler
