> On Feb. 20, 2013, 12:54 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 437 > > <https://reviews.apache.org/r/9408/diff/6/?file=258837#file258837line437> > > > > EXIT is used for messages that the mesos user / operator would read and > > need to take action in regard to. Given this is for orphaned executors, can > > you add more information to the message here to describe what could be > > wrong (so as to guide the user)? > > Vinod Kone wrote: > There are multiple reasons a cgroup 'destroy' fails, as you can see in > cgroups::destroy(). And, no, its not because another slave is running (see > below). Afaict, it is not possible to tell the reason from the call site. Any > ideas?
Ah thanks for explaining, sounds like this is unexpected and therefore should be a CHECK or LOG(FATAL)? Sounds like something we don't anticipate happening so EXIT seems to be the wrong technique to me. > On Feb. 20, 2013, 12:54 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 444 > > <https://reviews.apache.org/r/9408/diff/6/?file=258837#file258837line444> > > > > ditto, perhaps an indication that it's likely due to another slave > > running on this machine? > > Vinod Kone wrote: > Its not possible for another slave to be running, because we acquired the > exclusive lock. This could fail if 'fd' is invalid/refers to an object other > than file/incorrect descriptor. The strerror() would give the correct reason. Got it. Ditto then about CHECK or LOG(FATAL)? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16763 ----------------------------------------------------------- On Feb. 19, 2013, 10:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 10:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 14f549edaf1b37a6bca8f75309864333ae775e7c > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
