> On Feb. 20, 2013, 8:21 p.m., Benjamin Hindman wrote: > > src/tests/balloon_framework_test.sh, lines 14-15 > > <https://reviews.apache.org/r/9408/diff/7/?file=260009#file260009line14> > > > > Can we set this in one line?
i tested several possibilities, but couldn't get it to work with my limited bash fu :/ > On Feb. 20, 2013, 8:21 p.m., Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 92 > > <https://reviews.apache.org/r/9408/diff/7/?file=260008#file260008line92> > > > > This should really be handled by the slave. The isolation module is > > just responsible for the mechanisms of killing executors, not the policy. Turns out slave already does this! Though it doesn't wait for the cleanup to be completed :/ I have added a TODO for this now, since it requires a bit more refactoring and this review has already accumulated more changes than it indeed. More importantly the TODO is not imminent because it only affects the tests and not real world semantics. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16784 ----------------------------------------------------------- On Feb. 19, 2013, 10:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 10:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 14f549edaf1b37a6bca8f75309864333ae775e7c > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
