----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16784 -----------------------------------------------------------
src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment35661> This should really be handled by the slave. The isolation module is just responsible for the mechanisms of killing executors, not the policy. src/tests/balloon_framework_test.sh <https://reviews.apache.org/r/9408/#comment35668> Can we set this in one line? src/tests/balloon_framework_test.sh <https://reviews.apache.org/r/9408/#comment35669> s/cleanup/function cleanup/ Also, I'd like to see this documented. Why do we need this cleanup function? Maybe a note on why this function isn't pure (i.e., expects environment variables). - Benjamin Hindman On Feb. 19, 2013, 10:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 10:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 14f549edaf1b37a6bca8f75309864333ae775e7c > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
