----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8763/#review16991 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/8763/#comment36028> Maybe "archive" it by renaming it rather than deleting it? src/slave/slave.cpp <https://reviews.apache.org/r/8763/#comment36029> s/slaveinfo/SlaveInfo/ src/slave/slave.cpp <https://reviews.apache.org/r/8763/#comment36030> Should be a CopyFrom. Also, it is a bit of a hack, and the comment above should say something along the lines of needing to do this hack for the sake of _comparing_ the info created from the options/flags and what's been recovered. - Benjamin Hindman On Feb. 19, 2013, 8:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8763/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:08 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This checks slave info compatibility. Doesn't check version compatibility yet > (because its not clear how we get that info). > > > Diffs > ----- > > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > > Diff: https://reviews.apache.org/r/8763/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
